chore(firestore): remove redundant files#13208
Closed
sofisl wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes two JSON configuration files that defined reflection metadata for various Firestore bundle and helper classes, such as BundleElement, BundleMetadata, and LocalFirestoreHelper. As there are no review comments provided, I have no feedback to provide.
blakeli0
reviewed
May 15, 2026
Contributor
There was a problem hiding this comment.
I don't think they are redundant, the reflect-config.json under com.google.cloud.firestore.v1 is for proto gen code from proto-google-cloud-firestore-v1.
This file seems to be the GraalVM config for proto-google-cloud-firestore-bundle-v1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For googleapis/librarian#6012