feat(spanner): Cleanup GcpFallbackChannel creation and enable by default#12707
Open
kinsaurralde wants to merge 5 commits intogoogleapis:mainfrom
Open
feat(spanner): Cleanup GcpFallbackChannel creation and enable by default#12707kinsaurralde wants to merge 5 commits intogoogleapis:mainfrom
kinsaurralde wants to merge 5 commits intogoogleapis:mainfrom
Conversation
Contributor
kinsaurralde
commented
Apr 7, 2026
- Clean up setupGcpFallback by using new getDecoratedChannelBuilder instead of capturing cloudpath ChannelConfigurator
- Set EEF period to 3 minutes
- Enable fallback by default (still only used when direct access is enabled)
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables GCP fallback by default in SpannerOptions and refactors GapicSpannerRpc to simplify fallback channel setup using createDecoratedChannelBuilder. It also introduces a 3-minute period for fallback options. Feedback identifies a missing import for java.time.Duration and notes that the 10ms sleep in the integration tests is now insufficient to trigger the fallback check due to the increased period.
...nner/google-cloud-spanner/src/main/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpc.java
Show resolved
Hide resolved
.../google-cloud-spanner/src/test/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpcTest.java
Show resolved
Hide resolved
.../google-cloud-spanner/src/test/java/com/google/cloud/spanner/spi/v1/GapicSpannerRpcTest.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.