fix(pubsub/v2): fix span linking and add missing attributes#14326
Merged
hongalex merged 3 commits intogoogleapis:mainfrom Apr 13, 2026
Merged
fix(pubsub/v2): fix span linking and add missing attributes#14326hongalex merged 3 commits intogoogleapis:mainfrom
hongalex merged 3 commits intogoogleapis:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors OpenTelemetry tracing in the Pub/Sub v2 client to include full resource names in span attributes and adjust span kinds for better compliance with messaging conventions. Key changes include updating attribute helper functions to handle resource names and enhancing the subscriber's process span. A review comment points out that getProcessSpanAttributes should explicitly set the span kind to CONSUMER to align with the PR's objectives and the updated test cases.
feywind
approved these changes
Apr 2, 2026
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following
subscribespan kind should beINTERNALprocessspan kind should beCONSUMERgcp.resource.nameto spans