feat(storage): add resource span attributes for ACO ( App Centric Observability ) for async client#16151
feat(storage): add resource span attributes for ACO ( App Centric Observability ) for async client#16151bajajneha27 wants to merge 20 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a BucketMetadataCache to cache bucket metadata (ID and location) and uses it to enrich OpenTelemetry spans with destination resource attributes in both TracingConnection and AsyncConnectionTracing. When metadata is not cached, a background fetch is triggered. The review feedback highlights several important issues: a critical data race on bg_tasks_ in TracingConnection::MaybeTriggerBackgroundFetch due to a lack of mutex protection during push_back, potential undefined behavior in BucketMetadataCache::Put if max_size is initialized to 0, unnormalized bucket names on permission denied errors in TracingConnection, and performance concerns regarding the expensive creation of a new StorageConnection on every background fetch in AsyncConnectionTracing.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16151 +/- ##
========================================
Coverage 92.29% 92.29%
========================================
Files 2221 2221
Lines 207362 207583 +221
========================================
+ Hits 191378 191591 +213
- Misses 15984 15992 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
9450ced to
db490d9
Compare
4244a97 to
0f627af
Compare
…ervability ) for async client
fa71a12 to
f18bad4
Compare
No description provided.