feat: Support short-lived tokens in Credentials#347
Merged
Conversation
* Skip Client#fetch_access_token! in Credentials when token is already present. * Add Signet::OAuth2::Client#token_type * Add Signet::OAuth2::Client#needs_access_token? closes: googleapis#346
Member
Author
|
The acceptance test suites for google-cloud-bigquery and google-cloud-pubsub both pass for me locally when run against this change. I also generated a short-lived OAuth 2.0 token and manually tested using it with google-cloud-bigquery with this change. |
Member
Author
|
This was released in googleauth v1.1.0. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client#fetch_access_token!inCredentialswhen token is already present.Signet::OAuth2::Client#token_typeSignet::OAuth2::Client#needs_access_token?closes: #346