-
Notifications
You must be signed in to change notification settings - Fork 2.6k
chore: drop support for Python 3.7-3.9 #2770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,7 +22,7 @@ In order to add a feature: | |
| documentation. | ||
|
|
||
| - The feature must work fully on the following CPython versions: | ||
| 3.7, 3.8, 3.9, 3.10, 3.11, 3.12, 3.13 and 3.14 on both UNIX and Windows. | ||
| 3.10, 3.11, 3.12, 3.13, and 3.14 on both UNIX and Windows. | ||
|
|
||
| - The feature must not add unnecessary dependencies (where | ||
| "unnecessary" is of course subjective, but new dependencies should | ||
|
|
@@ -143,12 +143,12 @@ Running System Tests | |
| $ nox -s system | ||
|
|
||
| # Run a single system test | ||
| $ nox -s system-3.8 -- -k <name of test> | ||
| $ nox -s system-3.10 -- -k <name of test> | ||
|
|
||
|
|
||
| .. note:: | ||
|
|
||
| System tests are only configured to run under Python 3.8. | ||
| System tests are only configured to run under Python 3.10. | ||
| For expediency, we do not run them in older versions of Python 3. | ||
|
|
||
| This alone will not run the tests. You'll need to change some local | ||
|
|
@@ -195,11 +195,11 @@ configure them just like the System Tests. | |
|
|
||
| # Run all tests in a folder | ||
| $ cd samples/snippets | ||
| $ nox -s py-3.8 | ||
| $ nox -s py-3.10 | ||
|
|
||
| # Run a single sample test | ||
| $ cd samples/snippets | ||
| $ nox -s py-3.8 -- -k <name of test> | ||
| $ nox -s py-3.10 -- -k <name of test> | ||
|
|
||
| ******************************************** | ||
| Note About ``README`` as it pertains to PyPI | ||
|
|
@@ -221,18 +221,14 @@ Supported Python Versions | |
|
|
||
| We support: | ||
|
|
||
| - `Python 3.7`_ | ||
| - `Python 3.8`_ | ||
| - `Python 3.9`_ | ||
|
|
||
| - `Python 3.10`_ | ||
| - `Python 3.11`_ | ||
| - `Python 3.12`_ | ||
| - `Python 3.13`_ | ||
| - `Python 3.14`_ | ||
|
|
||
| .. _Python 3.7: https://docs.python.org/3.7/ | ||
| .. _Python 3.8: https://docs.python.org/3.8/ | ||
| .. _Python 3.9: https://docs.python.org/3.9/ | ||
|
|
||
| .. _Python 3.10: https://docs.python.org/3.10/ | ||
| .. _Python 3.11: https://docs.python.org/3.11/ | ||
| .. _Python 3.12: https://docs.python.org/3.12/ | ||
|
|
@@ -245,7 +241,7 @@ Supported versions can be found in our ``noxfile.py`` `config`_. | |
| .. _config: https://github.com/googleapis/google-api-python-client/blob/main/noxfile.py | ||
|
|
||
|
|
||
| We also explicitly decided to support Python 3 beginning with version 3.7. | ||
| We also explicitly decided to support Python 3 beginning with version 3.10. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since the minimum supported Python version is now 3.10, the reasons listed below (specifically the third bullet point regarding Unicode literal support for Python 2 and Python 3 compatibility) are obsolete and no longer applicable. Consider removing or updating that bullet point to reflect modern Python 3.10+ features. |
||
| Reasons for this include: | ||
|
|
||
| - Encouraging use of newest versions of Python 3 | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| pytest==7.4.4; python_version == '3.7' | ||
| pytest==8.2.2; python_version >= '3.8' | ||
| pytest==8.2.2 | ||
| flaky==3.8.1 | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Python 3.10 is now the minimum supported version, the note on the following line ('For expediency, we do not run them in older versions of Python 3.') is obsolete because there are no older supported versions of Python 3. Consider removing or updating that sentence to avoid confusion.