Add separate createBatch method to propagate batch URLs properly#584
Conversation
… per-service basis. Fix newline stripping in batching
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Add separate createBatch method to propagate batch URLs properly
|
@erickoledadevrel The default configuration does not contain trailing slashes: https://github.com/google/google-api-php-client/blob/master/src/Google/Config.php#L52 therefore, I took the approach to strip the trailing slash here and then add it at the combination step. I could add it back in the line above, but not really sure the benefit either way... |
|
The |
Presently, batch URLs use the system configured global URL and a hard-coded batch path. This PR allows for services to specify the batch end point.
It also fixes a problem with batches not correctly terminating headers when there is no body to the request.