fix: ensure class_exists is not called with null#2405
Merged
bshaffer merged 2 commits intogoogleapis:mainfrom Mar 17, 2023
Merged
fix: ensure class_exists is not called with null#2405bshaffer merged 2 commits intogoogleapis:mainfrom
bshaffer merged 2 commits intogoogleapis:mainfrom
Conversation
0ac2bcf to
5ea1a91
Compare
bshaffer
approved these changes
Mar 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
keyType()function inModel.phpwe were callingclass_exists()to find out if a class existed. However, in some cases the value that we were checking could be null. Since PHP 8.1 a deprecation warning is thrown. In this PR we check that the value that we are passing is not null before callingclass_exists(), thus removing the deprecationFixes #2372