feat: add support for PHP 8.2 ✨ #2359
Conversation
There was a problem hiding this comment.
Thank you for your contribution, but you're making a lot of changes here that we either don't want, are covered by #2350, or are confusing to me.
The only changes here I think we would need are:
- Upgrading nickinvision to v2 (why not?)
- Updating
.github/sync-repo-settings.yaml, although we don't need to add all the prefer lowest / stables - Potentially adding
ReturnTypeWillChangetoGoogle\Collection, although if this is a problem then I'm surprised that hasn't been reported elsewhere, and if so it still should be in a separate PR.
The changes I don't want here are:
- expanding the matrix to run prefer-lowest in every case
- adding all those extensions to the PHP build
- adding the plugin to composer.json (why?)
- running the CI on feature branches
|
|
|
|
These items will be addressed in #2431 |
Main changes