Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

fix: fix docs build for numbered lists#1740

Merged
parthea merged 13 commits intomainfrom
fix-docs-build-numbered-list
Sep 6, 2023
Merged

fix: fix docs build for numbered lists#1740
parthea merged 13 commits intomainfrom
fix-docs-build-numbered-list

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented Aug 14, 2023

Fixes #1723 🦕
Fixes #1724 🦕

@parthea parthea requested a review from a team August 14, 2023 15:05
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Aug 14, 2023
Copy link
Copy Markdown
Contributor

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's make this robust to numbered list entries whose numbers are more than one digit.

Comment thread gapic/utils/lines.py Outdated
Comment thread gapic/utils/lines.py Outdated
Comment thread tests/unit/utils/test_lines.py
@parthea parthea assigned vchudnov-g and unassigned parthea Sep 2, 2023
@parthea parthea force-pushed the fix-docs-build-numbered-list branch from 7e54960 to 90747b2 Compare September 2, 2023 10:50
Comment thread gapic/utils/lines.py Outdated
@parthea parthea deleted the fix-docs-build-numbered-list branch September 6, 2023 16:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size: m Pull request size is medium.

Projects

None yet

3 participants