Skip to content
This repository was archived by the owner on Jul 13, 2025. It is now read-only.

Update Python standalone sample template with lint fixes#2276

Merged
vchudnov-g merged 5 commits intogoogleapis:masterfrom
beccasaurus:update-python-standalone-template-for-linting
Aug 29, 2018
Merged

Update Python standalone sample template with lint fixes#2276
vchudnov-g merged 5 commits intogoogleapis:masterfrom
beccasaurus:update-python-standalone-template-for-linting

Conversation

@beccasaurus
Copy link
Copy Markdown
Contributor

@beccasaurus beccasaurus commented Aug 28, 2018

Update Python standalone sample template with lint fixes
  1. Don't start block comments with multiple # (#### No | # Yes)
  2. Lines < 80 characters

Related: GoogleCloudPlatform/python-docs-samples#1660 sample PR failing Lint (result output)

=> @vchudnov-g

Rebecca Taylor added 3 commits August 28, 2018 13:20
Fix Python standalone snips for Flake8 E266 rule
ea3b569 
Rule: Too many leading '#' for block comment (E266)
Best Practice: Start with one # only
Reference: https://lintlyci.github.io/Flake8Rules/rules/E266.html
Fix Python standalone snips for Flake8 E501 rule
b970a8c 
Rule: Line too long (> 79 characters) (E501)
Best Practice: Line lengths are recommended to be no greater than 79 characters
Reference: https://lintlyci.github.io/Flake8Rules/rules/E501.html
Update baseline for standalone Python sample lint fixes
fb3b102
@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 28, 2018 •
edited
Loading

Codecov Report

Merging #2276 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2276   +/-   ##
=========================================
  Coverage     86.76%   86.76%           
  Complexity     5135     5135           
=========================================
  Files           452      452           
  Lines         20400    20400           
  Branches       2190     2190           
=========================================
  Hits          17701    17701           
  Misses         1929     1929           
  Partials        770      770

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83411f3...4f955a6. Read the comment docs.

vchudnov-g
vchudnov-g reviewed Aug 28, 2018
View reviewed changes
Comment thread src/main/resources/com/google/api/codegen/py/standalone_sample.snip Outdated
@# DO NOT EDIT! This is a generated sample ("{@sample.callingForm}", "{@sample.valueSet.id}")

@# To run with the published packages, execute the following before running this code:
@# To run with the published packages, run the following before running code:

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

vchudnov-g
vchudnov-g approved these changes Aug 29, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@vchudnov-g vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer a slightly different wording, but we can change that later.

@vchudnov-g vchudnov-g merged commit 624bb86 into googleapis:master Aug 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@vchudnov-g vchudnov-g vchudnov-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Core: Sample-gen

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@beccasaurus @codecov-io @vchudnov-g