Skip to content
This repository was archived by the owner on Jul 13, 2025. It is now read-only.

Python: gax -> google.api_core#1656

Merged
lukesneeringer merged 6 commits intogoogleapis:masterfrom
landrito:python-api_core
Oct 31, 2017
Merged

Python: gax -> google.api_core#1656
lukesneeringer merged 6 commits intogoogleapis:masterfrom
landrito:python-api_core

Conversation

@landrito
Copy link
Copy Markdown
Contributor

@landrito landrito commented Oct 24, 2017 •
edited
Loading

What

This changes the generated libraries use google.api_core rather than to use gax.

Status

Ready for Review

Todo

Test that this works for the following APIs

  • Logging (Regular methods and page iteration)
  • VideoIntelligence (LRO)
  • Speech (Streaming)

Misc

cc @lukesneeringer

@landrito landrito force-pushed the python-api_core branch 2 times, most recently from e675c5d to 710509b Compare October 24, 2017 22:49
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 24, 2017 •
edited
Loading

Codecov Report

Merging #1656 into master will increase coverage by 0.02%.
The diff coverage is 98.16%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1656      +/-   ##
============================================
+ Coverage      85.5%   85.53%   +0.02%     
- Complexity     4274     4286      +12     
============================================
  Files           405      405              
  Lines         16804    16842      +38     
  Branches       1759     1762       +3     
============================================
+ Hits          14369    14405      +36     
  Misses         1849     1849              
- Partials        586      588       +2
Impacted Files Coverage Δ Complexity Δ
...api/codegen/viewmodel/OptionalArrayMethodView.java 100% <ø> (ø) 12 <0> (ø) ⬇️
...ansformer/py/PythonPackageMetadataTransformer.java 97.84% <100%> (-0.02%) 39 <0> (ø)
...n/transformer/DynamicLangApiMethodTransformer.java 99.28% <100%> (+0.02%) 27 <0> (ø) ⬇️
...transformer/py/PythonImportSectionTransformer.java 97.04% <100%> (-0.09%) 57 <6> (+2)
...codegen/viewmodel/testing/ClientTestClassView.java 100% <100%> (ø) 2 <1> (ø) ⬇️
.../codegen/transformer/PageStreamingTransformer.java 100% <100%> (ø) 13 <2> (+1) ⬆️
...api/codegen/transformer/py/PythonSurfaceNamer.java 90.15% <100%> (ø) 61 <0> (ø) ⬇️
...ransformer/py/PythonApiMethodParamTransformer.java 93.81% <100%> (+0.79%) 24 <1> (-4) ⬇️
...nsformer/py/PythonGapicSurfaceTestTransformer.java 98.83% <92.3%> (-1.17%) 32 <13> (+13)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75bc5be...241a256. Read the comment docs.

@landrito landrito force-pushed the python-api_core branch 2 times, most recently from 0cffff1 to 6ccf9d0 Compare October 24, 2017 23:56
@landrito landrito force-pushed the python-api_core branch 2 times, most recently from 69b68d4 to bb2540e Compare October 25, 2017 22:14
@landrito
Copy link
Copy Markdown
Contributor Author

landrito commented Oct 25, 2017 •
edited
Loading

cc @jonparrott

@theacodes
Copy link
Copy Markdown

theacodes commented Oct 26, 2017

google-api-core v0.1.0 has been released.

lukesneeringer
lukesneeringer reviewed Oct 31, 2017
View reviewed changes
Comment thread src/test/java/com/google/api/codegen/testdata/py/py_library.baseline
'shelves/{shelf}/books/{book}/returns/{return}',
shelf=shelf,
book=book,
return=return_,

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

lukesneeringer
lukesneeringer approved these changes Oct 31, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@lukesneeringer lukesneeringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix that return problem later, but this is good to merge.

@lukesneeringer lukesneeringer merged commit a461d99 into googleapis:master Oct 31, 2017
lukesneeringer added a commit that referenced this pull request Oct 31, 2017
@lukesneeringer
Revert "Python: gax -> google.api_core (#1656)"
3388d2e 
This reverts commit a461d99.
evaogbe pushed a commit to evaogbe/toolkit that referenced this pull request Nov 11, 2017
@landrito @evaogbe
Python: gax -> google.api_core (googleapis#1656)
2d75995
@landrito landrito deleted the python-api_core branch September 24, 2018 19:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@lukesneeringer lukesneeringer lukesneeringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@landrito @codecov-io @theacodes @lukesneeringer