This repository was archived by the owner on Apr 3, 2024. It is now read-only.
fix: Add more debugging info to the system e2e test#983
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #983 +/- ##
==========================================
- Coverage 66.90% 66.78% -0.12%
==========================================
Files 20 20
Lines 1668 1668
Branches 340 340
==========================================
- Hits 1116 1114 -2
- Misses 474 475 +1
- Partials 78 79 +1
Continue to review full report at Codecov.
|
mctavish
approved these changes
Jul 5, 2021
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Jul 6, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [5.2.6](https://www.github.com/googleapis/cloud-debug-nodejs/compare/v5.2.5...v5.2.6) (2021-07-06) ### Bug Fixes * Add more debugging info to the system e2e test ([#983](https://www.github.com/googleapis/cloud-debug-nodejs/issues/983)) ([5f670ee](https://www.github.com/googleapis/cloud-debug-nodejs/commit/5f670eefbb5828a9c211854f535ddce573c63d29)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The e2e test did not seem to fail in the past several months. We tend to close the issue for now with this PR, which adds more debugging information to the e2e test, so that if it failed again in the future, we would have more information to know what's the cause.
Fixes #946