Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/.OwlBot.lock.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
docker:
image: gcr.io/repo-automation-bots/owlbot-nodejs:latest
digest: sha256:6245a5be4c0406d9b2f04f380d8b88ffe4655df3cdbb57626f8913e8d620f4dd
digest: sha256:72ff93409133b0cf277b8870f859e1ddde62d2e329f655311d4bfc16735d182e
4 changes: 2 additions & 2 deletions .github/generated-files-bot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ generatedFiles:
- path: '.github/generated-files-bot.+(yml|yaml)'
message: '`.github/generated-files-bot.(yml|yaml)` should be updated in [`synthtool`](https://github.com/googleapis/synthtool)'
- path: 'README.md'
message: '`README.md` is managed by [`synthtool`](https://github.com/googleapis/synthtool). However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/master/.readme-partials.yaml'
message: '`README.md` is managed by [`synthtool`](https://github.com/googleapis/synthtool). However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml'
- path: 'samples/README.md'
message: '`samples/README.md` is managed by [`synthtool`](https://github.com/googleapis/synthtool). However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/master/.readme-partials.yaml'
message: '`samples/README.md` is managed by [`synthtool`](https://github.com/googleapis/synthtool). However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml'
ignoreAuthors:
- 'gcf-owl-bot[bot]'
- 'yoshi-automation'
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
on:
push:
branches:
- master
- main
pull_request:
name: ci
jobs:
Expand Down
2 changes: 1 addition & 1 deletion .kokoro/continuous/node10/common.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/continuous/node10/test.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/presubmit/node10/common.cfg

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/samples-test.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/system-test.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion .kokoro/test.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

[![release level](https://img.shields.io/badge/release%20level-beta-yellow.svg?style=flat)](https://cloud.google.com/terms/launch-stages)
[![npm version](https://img.shields.io/npm/v/@google-cloud/debug-agent.svg)](https://www.npmjs.org/package/@google-cloud/debug-agent)
[![codecov](https://img.shields.io/codecov/c/github/googleapis/cloud-debug-nodejs/master.svg?style=flat)](https://codecov.io/gh/googleapis/cloud-debug-nodejs)
[![codecov](https://img.shields.io/codecov/c/github/googleapis/cloud-debug-nodejs/main.svg?style=flat)](https://codecov.io/gh/googleapis/cloud-debug-nodejs)



Expand All @@ -15,7 +15,7 @@ Stackdriver Debug Agent for Node.js


A comprehensive list of changes in each version may be found in
[the CHANGELOG](https://github.com/googleapis/cloud-debug-nodejs/blob/master/CHANGELOG.md).
[the CHANGELOG](https://github.com/googleapis/cloud-debug-nodejs/blob/main/CHANGELOG.md).

* [Stackdriver Debugger Node.js Client API Reference][client-docs]
* [Stackdriver Debugger Documentation][product-docs]
Expand Down Expand Up @@ -58,12 +58,12 @@ npm install @google-cloud/debug-agent

## Samples

Samples are in the [`samples/`](https://github.com/googleapis/cloud-debug-nodejs/tree/master/samples) directory. Each sample's `README.md` has instructions for running its sample.
Samples are in the [`samples/`](https://github.com/googleapis/cloud-debug-nodejs/tree/main/samples) directory. Each sample's `README.md` has instructions for running its sample.

| Sample | Source Code | Try it |
| --------------------------- | --------------------------------- | ------ |
| App | [source code](https://github.com/googleapis/cloud-debug-nodejs/blob/master/samples/app.js) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/cloud-debug-nodejs&page=editor&open_in_editor=samples/app.js,samples/README.md) |
| Snippets | [source code](https://github.com/googleapis/cloud-debug-nodejs/blob/master/samples/snippets.js) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/cloud-debug-nodejs&page=editor&open_in_editor=samples/snippets.js,samples/README.md) |
| App | [source code](https://github.com/googleapis/cloud-debug-nodejs/blob/main/samples/app.js) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/cloud-debug-nodejs&page=editor&open_in_editor=samples/app.js,samples/README.md) |
| Snippets | [source code](https://github.com/googleapis/cloud-debug-nodejs/blob/main/samples/snippets.js) | [![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/cloud-debug-nodejs&page=editor&open_in_editor=samples/snippets.js,samples/README.md) |



Expand Down Expand Up @@ -111,19 +111,19 @@ More Information: [Google Cloud Platform Launch Stages][launch_stages]

## Contributing

Contributions welcome! See the [Contributing Guide](https://github.com/googleapis/cloud-debug-nodejs/blob/master/CONTRIBUTING.md).
Contributions welcome! See the [Contributing Guide](https://github.com/googleapis/cloud-debug-nodejs/blob/main/CONTRIBUTING.md).

Please note that this `README.md`, the `samples/README.md`,
and a variety of configuration files in this repository (including `.nycrc` and `tsconfig.json`)
are generated from a central template. To edit one of these files, make an edit
to its template in this
[directory](https://github.com/googleapis/synthtool/tree/master/synthtool/gcp/templates/node_library).
to its templates in
[directory](https://github.com/googleapis/synthtool).

## License

Apache Version 2.0

See [LICENSE](https://github.com/googleapis/cloud-debug-nodejs/blob/master/LICENSE)
See [LICENSE](https://github.com/googleapis/cloud-debug-nodejs/blob/main/LICENSE)

[client-docs]: https://cloud.google.com/nodejs/docs/reference/debug-agent/latest
[product-docs]: https://cloud.google.com/debugger
Expand Down
4 changes: 2 additions & 2 deletions samples/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Before running the samples, make sure you've followed the steps outlined in

### App

View the [source code](https://github.com/googleapis/cloud-debug-nodejs/blob/master/samples/app.js).
View the [source code](https://github.com/googleapis/cloud-debug-nodejs/blob/main/samples/app.js).

[![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/cloud-debug-nodejs&page=editor&open_in_editor=samples/app.js,samples/README.md)

Expand All @@ -49,7 +49,7 @@ __Usage:__

### Snippets

View the [source code](https://github.com/googleapis/cloud-debug-nodejs/blob/master/samples/snippets.js).
View the [source code](https://github.com/googleapis/cloud-debug-nodejs/blob/main/samples/snippets.js).

[![Open in Cloud Shell][shell_img]](https://console.cloud.google.com/cloudshell/open?git_repo=https://github.com/googleapis/cloud-debug-nodejs&page=editor&open_in_editor=samples/snippets.js,samples/README.md)

Expand Down
10 changes: 4 additions & 6 deletions src/types/v8.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
// TODO: Determine if the use of snake case should be allowed in this file.
/* eslint-disable @typescript-eslint/no-explicit-any */

// See https://github.com/v8/v8/blob/master/src/debug/mirrors.js
// See https://chromium.googlesource.com/v8/v8.git/+/refs/heads/main/src/inspector/value-mirror.cc

export declare type MirrorType =
| 'undefined'
Expand Down Expand Up @@ -133,7 +133,7 @@ export interface PropertyMirror extends Mirror {

export interface FrameDetails {
// TODO: The debug code expects this to have `arguments` and `locals` fields.
// The code at https://github.com/v8/v8/blob/master/src/debug/mirrors.js
// The code at https://chromium.googlesource.com/v8/v8.git/+/refs/heads/main/src/inspector/value-mirror.cc
// seems to suggest that these fields should exist. Make sure that is
// the case.
arguments: Array<{
Expand Down Expand Up @@ -283,8 +283,7 @@ export interface FunctionMirror extends ObjectMirror {
context: () => ContextMirror;
}

// See https://github.com/v8/v8/blob/master/src/debug/debug.js and
// https://github.com/nodejs/node/blob/master/src/node_contextify.cc
// See https://chromium.googlesource.com/v8/v8.git/+/refs/heads/main/test/debugger/test-api.js
export interface ExecutionState {
// This interface only contains the elements used within the debug agent
// for the full implementation.
Expand Down Expand Up @@ -323,8 +322,7 @@ export interface DebugEvent {
AsyncTaskEvent: DebugEvent;
}

// See https://github.com/v8/v8/blob/master/src/debug/debug.js
// TODO: Add the rest of the methods in this interface
// See https://chromium.googlesource.com/v8/v8.git/+/refs/heads/main/test/debugger/test-api.js
export interface Debug {
DebugEvent: DebugEvent;
setListener: (listener: any, opt_data?: any) => void;
Expand Down