This repository was archived by the owner on Sep 27, 2023. It is now read-only.
chore: Convert existing CI workflows to maven - #376
Merged
Conversation
blakeli0
reviewed
Nov 22, 2022
blakeli0
reviewed
Nov 22, 2022
blakeli0
reviewed
Nov 22, 2022
blakeli0
reviewed
Nov 22, 2022
lqiu96
commented
Nov 22, 2022
lqiu96
commented
Nov 22, 2022
lqiu96
commented
Nov 22, 2022
Member
Author
|
We are going to determine if the java.header file should have |
lqiu96
commented
Nov 28, 2022
Comment on lines
+2
to
+29
| ^ \* Copyright 20\d\d,? Google (Inc\.|LLC)( All [rR]ights [rR]eserved\.)?$ | ||
| ^ \*$ | ||
| ^ \* Licensed under the Apache License, Version 2\.0 \(the "License"\);$ | ||
| ^ \* you may not use this file except in compliance with the License\.$ | ||
| ^ \* You may obtain a copy of the License at$ | ||
| ^ \* Redistribution and use in source and binary forms, with or without$ | ||
| ^ \* modification, are permitted provided that the following conditions are$ | ||
| ^ \* met:$ | ||
| ^ \*$ | ||
| ^ \*[ ]+https?://www.apache.org/licenses/LICENSE-2\.0$ | ||
| ^ \* \* Redistributions of source code must retain the above copyright$ | ||
| ^ \* notice, this list of conditions and the following disclaimer.$ | ||
| ^ \* \* Redistributions in binary form must reproduce the above$ | ||
| ^ \* copyright notice, this list of conditions and the following disclaimer$ | ||
| ^ \* in the documentation and/or other materials provided with the$ | ||
| ^ \* distribution.$ | ||
| ^ \* \* Neither the name of Google (Inc\.|LLC) nor the names of its$ | ||
| ^ \* contributors may be used to endorse or promote products derived from$ | ||
| ^ \* this software without specific prior written permission.$ | ||
| ^ \*$ | ||
| ^ \* Unless required by applicable law or agreed to in writing, software$ | ||
| ^ \* distributed under the License is distributed on an "AS IS" BASIS,$ | ||
| ^ \* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied\.$ | ||
| ^ \* See the License for the specific language governing permissions and$ | ||
| ^ \* limitations under the License\.$ | ||
| ^ \*/$ | ||
| ^ \* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS$ | ||
| ^ \* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT$ | ||
| ^ \* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR$ | ||
| ^ \* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT$ | ||
| ^ \* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,$ | ||
| ^ \* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES \(INCLUDING, BUT NOT$ | ||
| ^ \* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,$ | ||
| ^ \* DATA, OR PROFITS; OR BUSINESS INTERRUPTION\) HOWEVER CAUSED AND ON ANY$ | ||
| ^ \* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT$ | ||
| ^ \* \(INCLUDING NEGLIGENCE OR OTHERWISE\) ARISING IN ANY WAY OUT OF THE USE$ | ||
| ^ \* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.$ | ||
| ^ \*/$ No newline at end of file |
Member
Author
There was a problem hiding this comment.
This is the same as license-header-javadoc.txt which gradle has been using. Nothing about the license changes except that maven uses this file.
I've updated it to accept Google Inc and LLC
blakeli0
approved these changes
Nov 29, 2022
Member
Author
|
I'm going to temporarily re-add in the old I'll create a separate PR to remove the old workflows and update the status checks.On second thought, I probably don't need to remove the required status checks.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to convert existing CI workflows to maven. There are a few changes in this PR: