Skip to content

Add support for mapId option.#1086

Open
jakeFeldman wants to merge 2 commits intogoogle-map-react:masterfrom
jakeFeldman:add-mapid-support
Open

Add support for mapId option.#1086
jakeFeldman wants to merge 2 commits intogoogle-map-react:masterfrom
jakeFeldman:add-mapid-support

Conversation

@jakeFeldman
Copy link
Copy Markdown

@jakeFeldman jakeFeldman commented Jan 9, 2022 •
edited
Loading

Description

This PR adds support for mapId. By default mapId works by adding to the options prop, but we get a warning in the console. This resolves said warning by removing the styles property from the maps option.

I've updated the type defs in the DefinitelyTyped repo as well (PR here)

A Map's styles property cannot be set when a mapId is present.  When a mapId is present Map styles are controlled via the cloud console. Please see documentation at https://developers.google.com/maps/documentation/javascript/styling#cloud_tooling

closes #1070

@jakeFeldman jakeFeldman mentioned this pull request Jan 9, 2022
Open
@jakeFeldman
Copy link
Copy Markdown
Author

jakeFeldman commented Jan 11, 2022

Hello @itsmichaeldiego, I'm reaching out to see if you could take a look at this PR. It's enabling mapId support inside map options. Thanks in advance!

@strarsis
Copy link
Copy Markdown

strarsis commented Nov 22, 2022 •
edited
Loading

@jakeFeldman: Awesome! I really need this as I want to use such a map style by map ID!
Edit: Found out by your answer that a mapId can already be used (with a JavaScript warning): #1070 (comment)

@strarsis
Copy link
Copy Markdown

strarsis commented Nov 22, 2022 •
edited
Loading

@jakeFeldman: Also note that the mapId can only be changed (after it was set) by completely resetting the Google Maps instance (see https://stackoverflow.com/a/62947623/4150808).

@humbroll
Copy link
Copy Markdown

humbroll commented Aug 29, 2023

I need this PR as well. I hope it's merged to the main. Is this project not active anymore? It seems like it's been a while since the PR was created.

@jakeFeldman
Copy link
Copy Markdown
Author

jakeFeldman commented Aug 29, 2023

Not too sure. Doesn't seem like its maintained anymore.

@kevin1193
Copy link
Copy Markdown

kevin1193 commented Sep 4, 2023

Waiting for this to be merged! Would be a good feature.

agustingabiola
agustingabiola reviewed Sep 19, 2023
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gevvvvv gevvvvv Awaiting requested review from gevvvvv

@agustingabiola agustingabiola Awaiting requested review from agustingabiola

1 more reviewer

@dfiedlerx dfiedlerx dfiedlerx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide a way to set map id.

7 participants

@jakeFeldman @strarsis @humbroll @kevin1193 @agustingabiola @gevvvvv @dfiedlerx