Fix connections in Apis#5
Merged
Merged
Conversation
Fixing the previous attempt to rename _database_connection to _connection by changing all references to the variable _connection to _spanner_connection. Also applying the same change to the admin api
akefeli
approved these changes
Nov 6, 2018
dcbrandao
added a commit
that referenced
this pull request
Nov 6, 2018
Adding regression tests for the issue that was fixed in PR #5. As part of the testing, switched over many places that were detecting errors caused by improper library usage to better errors than AssertionError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the previous attempt to rename _database_connection to
_connection by changing all references to the variable _connection to
_spanner_connection. Also applying the same change to the admin api