Make model specification and loading more robust#47
Merged
Conversation
Right now, in relationships and parent table specifications, specifying the model name requires a fully-specified class name. Adding a registry so we don't have to load classes on the fly and instead register classes as they load, so we can specify a less-qualified class name and avoid having to read files to resolve a model class
akefeli
approved these changes
Mar 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, in relationships and parent table specifications, specifying
the model name requires a fully-specified class name. Adding a registry
so we don't have to load classes on the fly and instead register classes
as they load, so we can specify a less-qualified class name and avoid
having to read files to resolve a model class