Support length for various fields#176
Merged
Merged
Conversation
| if self._nullable: | ||
| return self._type.ddl() | ||
| return '{field_type} NOT NULL'.format(field_type=self._type.ddl()) | ||
| return f'{base_ddl}' |
dseomn
reviewed
Sep 15, 2022
dseomn
reviewed
Sep 16, 2022
Contributor
dseomn
left a comment
There was a problem hiding this comment.
I've got more nits on the code, but I still want to figure out the API more, so I'm not sure it's worth addressing the nits until we have a better idea of what the API should look like. (See the comment from my previous review.)
dseomn
suggested changes
Sep 28, 2022
Author
|
Ready for another round of review now. |
dseomn
approved these changes
Sep 30, 2022
dseomn
approved these changes
Oct 3, 2022
dseomn
approved these changes
Oct 3, 2022
Contributor
dseomn
left a comment
There was a problem hiding this comment.
LGTM. I'm not sure why status checks aren't running.
Contributor
|
Mind pulling in the latest changes from #190 ? I'm hoping that will get github to run the tests on this so we can merge it. |
added 11 commits
October 3, 2022 14:42
Author
|
Just rebased. It seems that it requires you to approve running workflows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.