Skip to content

Issue 259: Add 🔑 parameters to help string#275

Closed
amy-lei wants to merge 3 commits into
google:masterfrom
amy-lei:key-param
Closed

Issue 259: Add 🔑 parameters to help string#275
amy-lei wants to merge 3 commits into
google:masterfrom
amy-lei:key-param

Conversation

@amy-lei

@amy-lei amy-lei commented Jul 27, 2020

Copy link
Copy Markdown
Contributor

Resolves #259

Add :key: parameters under flags as so

FLAGS
    --arg=ARG
    The following flags are also accepted.
    --key
        Description of the `key` kwarg from the docstring
    Additional undocumented flags may also be accepted.

@google-cla google-cla Bot added the cla: yes Author has signed CLA label Jul 27, 2020
@amy-lei
amy-lei marked this pull request as ready for review August 3, 2020 20:22
@dbieber

dbieber commented Aug 5, 2020

Copy link
Copy Markdown
Collaborator

Thanks for the PR! I haven't had a chance to look in detail yet. Will let you know once I do.
🙏

python-fire-bot pushed a commit that referenced this pull request Dec 16, 2020
a22cb7d by Amy <leiamy12@gmail.com>
26aba55 by Amy <leiamy12@gmail.com>
9bcccf9 by Amy <leiamy12@gmail.com>

COPYBARA_INTEGRATE_REVIEW=#275 from amy-lei:key-param 9bcccf9
PiperOrigin-RevId: 347874060
Change-Id: Id7d59472a73bf1fa33d37334e7e72702a07c72f6
@dbieber

dbieber commented Dec 16, 2020

Copy link
Copy Markdown
Collaborator

Merged with aa18534

Thanks for the contribution!

@dbieber dbieber closed this Dec 16, 2020
CherylMoonba added a commit to CherylMoonba/devices that referenced this pull request Jul 20, 2025
a22cb7dd08c49357cdc5bf62d59d6c650fb9548b by Amy <leiamy12@gmail.com>
26aba559cef2ad07ea0516e92db029ee04956a16 by Amy <leiamy12@gmail.com>
9bcccf992b15d1eebb05a3e2267bc6228269dd90 by Amy <leiamy12@gmail.com>

COPYBARA_INTEGRATE_REVIEW=google/python-fire#275 from amy-lei:key-param 9bcccf992b15d1eebb05a3e2267bc6228269dd90
PiperOrigin-RevId: 347874060
Change-Id: Id7d59472a73bf1fa33d37334e7e72702a07c72f6
hwlegends pushed a commit to hwlegends/python-fire that referenced this pull request Aug 20, 2025
a22cb7dd08c49357cdc5bf62d59d6c650fb9548b by Amy <leiamy12@gmail.com>
26aba559cef2ad07ea0516e92db029ee04956a16 by Amy <leiamy12@gmail.com>
9bcccf992b15d1eebb05a3e2267bc6228269dd90 by Amy <leiamy12@gmail.com>

COPYBARA_INTEGRATE_REVIEW=google/python-fire#275 from amy-lei:key-param 9bcccf992b15d1eebb05a3e2267bc6228269dd90
PiperOrigin-RevId: 347874060
Change-Id: Id7d59472a73bf1fa33d37334e7e72702a07c72f6
Hernandez19891 added a commit to Hernandez19891/Illumina that referenced this pull request Sep 15, 2025
a22cb7dd08c49357cdc5bf62d59d6c650fb9548b by Amy <leiamy12@gmail.com>
26aba559cef2ad07ea0516e92db029ee04956a16 by Amy <leiamy12@gmail.com>
9bcccf992b15d1eebb05a3e2267bc6228269dd90 by Amy <leiamy12@gmail.com>

COPYBARA_INTEGRATE_REVIEW=google/python-fire#275 from amy-lei:key-param 9bcccf992b15d1eebb05a3e2267bc6228269dd90
PiperOrigin-RevId: 347874060
Change-Id: Id7d59472a73bf1fa33d37334e7e72702a07c72f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Author has signed CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🔑 parameter documentation doesn't correctly display in help signature

2 participants