Repository navigation
Apple's BoringSSL integration sets SSL_OP_NO_TLSv1_3 whenever sec_protocol_options_add_pre_shared_key is configured with a minimum TLS version below TLS 1.3, preventing a single static sec_protocol_options_t from negotiating both TLS 1.3 mTLS and legacy TLS 1.2 PSK (0x00A8). - #4738
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
cl/1004285304
branch
4 times, most recently
from
October 28, 2026 08:11
4987502 to
fbd8c8d
Compare
…protocol_options_add_pre_shared_key` is configured with a minimum TLS version below TLS 1.3, preventing a single static `sec_protocol_options_t` from negotiating both TLS 1.3 mTLS and legacy TLS 1.2 PSK (`0x00A8`). On the server role in `GNCNWParameters`, prepend a custom `nw_framer_t` (`com.google.nearby.ServerTLSSelector`) that inspects incoming `ClientHello` cipher suites via `GNCClientHelloOffersTLS13` and dynamically prepends either `GNCConfigureTLS13MutualAuthOptions` or `GNCConfigureTLS12PSKOptions` before delivering the buffered `ClientHello` to the TLS layer. On the client role in `GNCNWFramework`, extract `connectToEndpoint:withParameters:cancelSource:queue:error:` and retry once with `GNCBuildTLS12PSKParameters` when an outbound connection with PSK credentials fails under TLS 1.3 mTLS without cancellation via `cancelSource`. PiperOrigin-RevId: 1004285304
copybara-service
Bot
force-pushed
the
cl/1004285304
branch
from
October 28, 2026 20:35
fbd8c8d to
76e03d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apple's BoringSSL integration sets
SSL_OP_NO_TLSv1_3wheneversec_protocol_options_add_pre_shared_keyis configured with a minimum TLS version below TLS 1.3, preventing a single staticsec_protocol_options_tfrom negotiating both TLS 1.3 mTLS and legacy TLS 1.2 PSK (0x00A8).On the server role in
GNCNWParameters, prepend a customnw_framer_t(com.google.nearby.ServerTLSSelector) that inspects incomingClientHellocipher suites viaGNCClientHelloOffersTLS13and dynamically prepends eitherGNCConfigureTLS13MutualAuthOptionsorGNCConfigureTLS12PSKOptionsbefore delivering the bufferedClientHelloto the TLS layer.On the client role in
GNCNWFramework, extractconnectToEndpoint:withParameters:cancelSource:queue:error:and retry once withGNCBuildTLS12PSKParameterswhen an outbound connection with PSK credentials fails under TLS 1.3 mTLS without cancellation viacancelSource.