Skip to content

feat: Add ListDockerMigrationConflictingPackages for orgs and users - #4706

Merged
gmlewis merged 1 commit into
google:masterfrom
10kartik:add-docker-conflicts
Nov 10, 2026
Merged

gmlewis merged 1 commit into
google:masterfrom
10kartik:add-docker-conflicts

Conversation

@10kartik

@10kartik 10kartik commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Adds the three "conflicting packages during Docker migration" endpoints:

  • OrganizationsService.ListDockerMigrationConflictingPackages - GET /orgs/{org}/docker/conflicts
  • UsersService.ListDockerMigrationConflictingPackages - GET /user/docker/conflicts and GET /users/{username}/docker/conflicts

The users method follows UsersService.ListPackages: an empty user means the authenticated user. None of these endpoints take pagination parameters, so there are no Iter methods.

I used Claude Code to help write this and reviewed every line myself.

🤖 Generated with Claude Code

@codecov

codecov Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.64%. Comparing base (dac8c26) to head (54bf276).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4706   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files         204      204           
  Lines       19080    19101   +21     
=======================================
+ Hits        18822    18843   +21     
  Misses        258      258           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Nov 10, 2026

@gmlewis gmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @10kartik!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @Not-Dhananjay-Mishra

@Not-Dhananjay-Mishra Not-Dhananjay-Mishra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Nov 10, 2026
@gmlewis
gmlewis merged commit 0cbd0f5 into google:master Nov 10, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants