Repository navigation
Conversation
vibbix
marked this pull request as ready for review
November 6, 2026 17:42
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4703 +/- ##
=======================================
Coverage 98.64% 98.64%
=======================================
Files 204 204
Lines 19080 19080
=======================================
Hits 18822 18822
Misses 258 258 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gmlewis
approved these changes
Nov 8, 2026
gmlewis
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @vibbix and @Not-Dhananjay-Mishra!
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As part of work for integrations/terraform-provider-github#3721 I needed to pull in some new fields into this provider.
InstallationPermissionshas no field for eight permissions GitHub now returns, so callers can't read them off an app or installation, and can't request them when scoping down an installation token.Six are in the
app-permissionsschema of GitHub's OpenAPI description:artifact_metadata,code_quality,custom_properties_for_organizations,organization_copilot_agent_settings,organization_copilot_requestsandorganization_external_properties_for_repos. The other two,repository_creationandinstallation_repositories, were announced in the October 13 changelog and aren't in the OpenAPI description yet.How this was tested
Accessors and their tests come from
script/generate.sh.script/test.shandscript/lint.shpass.AI Disclosure
Claude 5.5 @ High helped triage this