Skip to content

fix: Accept 202 when deleting app installation - #4529

Merged
gmlewis merged 3 commits into
google:masterfrom
keeltrace:keeltrace/apps-delete-installation-202-4077
Sep 8, 2026
Merged

gmlewis merged 3 commits into
google:masterfrom
keeltrace:keeltrace/apps-delete-installation-202-4077

Conversation

@keeltrace

@keeltrace keeltrace commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

Summary

GitHub REST API version 2026-03-10 changed DELETE /app/installations/{installation_id} from a 204 No Content success response to 202 Accepted.

Client.Do intentionally represents HTTP 202 as AcceptedError, so AppsService.DeleteInstallation currently returns an error for the endpoint's new successful response. This change treats 202 as success for this endpoint and updates the regression test accordingly.

This is intentionally scoped to the corresponding checkbox in #4077; other App APIs are unchanged.

Verification

  • go test ./github -run '^TestAppsService_DeleteInstallation$'
  • script/fmt.sh
  • git diff --check
  • full repository CI is also running on the submitted commit

Ref #4077

AI-assisted contribution: ChatGPT helped identify the tracked migration item, inspect the 202 handling path, and draft the change. I reviewed the final diff and verification results.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants