Skip to content

Improve TS types to support isolatedModules and isolatedDeclarations#9029

Open
bjornharrtell wants to merge 4 commits intomasterfrom
ts-type-improvements
Open

Improve TS types to support isolatedModules and isolatedDeclarations#9029
bjornharrtell wants to merge 4 commits intomasterfrom
ts-type-improvements

Conversation

@bjornharrtell
Copy link
Copy Markdown
Collaborator

@bjornharrtell bjornharrtell commented Apr 8, 2026

ref #9028

@bjornharrtell
Copy link
Copy Markdown
Collaborator Author

The large amount of changes are due to that the the files has been re-generated with the code generator.

It should have amounted to much smaller difference, but I see generated code has been subjected to automated formatting in #8707. Did that intentionally also apply for generated code @dbaileychess? I find it hard to understand rationale for that, or at least it would mean it should be applied again after new code gen but I'm not sure the tooling for it is available outside google.

@github-actions github-actions Bot added the grpc label Apr 8, 2026
@jtdavis777
Copy link
Copy Markdown
Collaborator

I'm not sure how to go about reviewing this given the large scale of changes. Do you have a quick tl;dr on the non code gen changes?

@bjornharrtell
Copy link
Copy Markdown
Collaborator Author

bjornharrtell commented Apr 18, 2026

@jtdavis777 issue reference in the PR description was wrong. Fixed now (#9028) and with rationale for the changes.

As for the relevant manual changes here it's in the ts code gen (src/idl_gen_ts.cpp) adding explicit declaration and return types. Additionally for the non generated typescript implementation same kind of fixes has been done manually (in ts/flexbuffers/stack-value.ts, ts/flatbuffers.ts and ts/utils.ts).

Remaining diff is due to code gen which looks extreme due to #8707.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants