Allow specifying threshold_abs and threshold_rel. This fixes the drop-everything-under-zero bug in ExaSPIM#119
Merged
copybara-service[bot] merged 1 commit intomasterfrom Apr 9, 2026
Conversation
e6f38d5 to
26ff7f7
Compare
…drop-everything-under-zero bug in ExaSPIM PiperOrigin-RevId: 897242664
26ff7f7 to
b0716af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow specifying
threshold_absandthreshold_rel. This fixes the drop-everything-under-zero bug in ExaSPIM