Skip to content

Updating explorer structures and functions#37

Merged
roshanmaskey merged 5 commits intogoogle:v0.6.0from
roshanmaskey:v0.6.0
Apr 13, 2026
Merged

Updating explorer structures and functions#37
roshanmaskey merged 5 commits intogoogle:v0.6.0from
roshanmaskey:v0.6.0

Conversation

@roshanmaskey
Copy link
Copy Markdown
Collaborator

Changes:

  • Updated structure to include ContainerType field. This indicates docker, container, or podman.
  • Updated params and variable names to match Golang style guide.
  • Added a new interface function GetContainerByID.
  • Added a common function ScanDiffDirectory.

dependabot Bot and others added 4 commits November 6, 2025 15:17
Bumps the go_modules group with 1 update in the / directory: [github.com/containerd/containerd](https://github.com/containerd/containerd).


Updates `github.com/containerd/containerd` from 1.7.11 to 1.7.29
- [Release notes](https://github.com/containerd/containerd/releases)
- [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md)
- [Commits](containerd/containerd@v1.7.11...v1.7.29)

Updates `golang.org/x/net` from 0.36.0 to 0.42.0
- [Commits](golang/net@v0.36.0...v0.42.0)

---
updated-dependencies:
- dependency-name: github.com/containerd/containerd
  dependency-version: 1.7.29
  dependency-type: direct:production
  dependency-group: go_modules
- dependency-name: golang.org/x/net
  dependency-version: 0.42.0
  dependency-type: indirect
  dependency-group: go_modules
...

Signed-off-by: dependabot[bot] <support@github.com>
…ules-2f335dec32

Bump the go_modules group across 1 directory with 2 updates
@roshanmaskey roshanmaskey requested a review from Fryyyyy April 10, 2026 05:25
Comment thread explorers/containerd/containerd.go Outdated
imageRoot string // mounted image path
containerdRoot string
dockerRoot string
// root string // containerd root
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

Comment thread explorers/containerd/containerd.go Outdated

// NewExplorer returns a ContainerExplorer interface to explore containerd.
func NewExplorer(imageroot string, root string, manifest string, snapshot string, layercache string, sc *explorers.SupportContainer) (explorers.ContainerExplorer, error) {
// func NewExplorer(imageroot string, root string, manifest string, snapshot string, layercache string, sc *explorers.SupportContainer) (explorers.ContainerExplorer, error) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old function signature?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment thread explorers/containerd/containerd.go Outdated
@@ -77,8 +91,12 @@ func NewExplorer(imageroot string, root string, manifest string, snapshot string
// The default snapshot root directrion location for containerd is
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

directrion ?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Comment thread explorers/containerd/containerd.go Outdated
}

dirs, _ := filepath.Glob(filepath.Join(e.containerdRoot, "*"))
snapshotRoot := "unknown"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could put this above and return it instead of a raw string with the same contents

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@roshanmaskey roshanmaskey merged commit a6015e1 into google:v0.6.0 Apr 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants