[BlackboxBenchmarking] Replace INTERVAL duration fields with DOUBLE duration_seconds#5278
Open
dylanjew wants to merge 1 commit into
Open
[BlackboxBenchmarking] Replace INTERVAL duration fields with DOUBLE duration_seconds#5278dylanjew wants to merge 1 commit into
dylanjew wants to merge 1 commit into
Conversation
F1 doesn't support INTERVAL types natively (b/213368390). This PR replaces the INTERVAL duration fields with DOUBLE duration_seconds. ### Rollout I plan to just drop the existing cluster-fuzz.fuzzer_stats.daily_stats table after this is deployed and rerunning the job to backfill the data. Since there are no consumers of this data yet, this seems simpler than doing a dual write + alter table drop column, then changing the job load to stop including the old rows. The concern I had is that a BigQuery load without the old rows would fail, so dropping the table after this is deployed and then backfilling seems like a simpler approach. ### Testing I verified the SQL query by running it in BigQuery against the cluster-fuzz.fuzzer_stats.daily_stats table.
aakallam
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F1 doesn't support INTERVAL types natively (b/213368390). This PR replaces the
INTERVALduration fields incluster-fuzz.fuzzer_stats.daily_statswithDOUBLEduration_seconds.Rollout
I plan to just drop the existing
cluster-fuzz.fuzzer_stats.daily_statstable after this is deployed and rerun the job to backfill the data. Since there are no consumers of this data yet, this seems simpler than doing a dual write + alter table drop column, then changing the job load to stop including the old rows.The concern I had is that a BigQuery load without the old rows would fail, so dropping the table after this is deployed and then backfilling seems like a simpler approach.
Testing
I verified the SQL query by running it in BigQuery against the
cluster-fuzz.fuzzer_stats.daily_statstable.I dropped the table in dev and ran the cron with the new fields. https://paste.googleplex.com/5110869211086848
https://screenshot.googleplex.com/7iTMbm3Ry6J22ZQ