feat(tools): Preserve Field descriptions in set_model_response schema - #6715
Open
a2105z wants to merge 1 commit into
Open
feat(tools): Preserve Field descriptions in set_model_response schema#6715a2105z wants to merge 1 commit into
a2105z wants to merge 1 commit into
Conversation
build_function_declaration rebuilds parameters from inspect.Parameter, which cannot carry Pydantic Field(description=...) metadata, so semantic hints in output_schema were dropped before reaching the model. Re-apply those descriptions onto the generated tool declaration. Fixes google#6707
Contributor
Author
|
Hi @sanketpatil06 @GWeale @DeanChensj — ready for review. This lands #6707: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
output_schemauses PydanticField(description=...), those descriptions were lost in the generatedset_model_responsetool schema because declaration build goes throughinspect.Parameter(no description channel).SetModelResponseTool._get_declarationnow re-applies field descriptions from the original output schema onto the tool parameters.$defspath).Fixes #6707
Test plan
Field(description=...)now appears inparameters_json_schema.properties.*.descriptionpytest tests/unittests/tools/test_set_model_response_tool.py— 33 passedMade with Cursor