fix(a2a): Support instruction providers in cards#6451
Draft
March-77 wants to merge 1 commit into
Draft
Conversation
Agent cards are static and have no ReadonlyContext, so passing callable instructions into description or example regexes crashes card generation. Include only static strings and leave runtime providers unexecuted. Fixes google#6450
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
Problem:
LlmAgent.instructionandglobal_instructionmay be runtimeInstructionProvidercallables, but the static Agent Card builder passed them to string regexes for description and example extraction. Card generation therefore failed before the A2A agent could start.Solution:
Only include string instructions in static card descriptions and examples. Providers require a real
ReadonlyContext, so card generation leaves them unexecuted while preserving the agent description, default description, and existing string-instruction behavior.Testing Plan
Unit Tests:
Passed:
pytest tests/unittests/a2a/utils -q: 110 passed, 2 skippeduv build: sdist and wheel built successfullyThe repository-wide Windows run reached 9,059 passed, 66 skipped, and 18 xfailed; 40 unrelated tests failed on Windows path-length, shell, line-ending, and filesystem integration assumptions. The changed A2A suite is fully green. The pre-commit
check-new-py-prefixwrapper also expects/bin/bashand cannot launch natively on Windows; no files were added, and the script passes when invoked directly with Git Bash.Manual End-to-End (E2E) Tests:
Ran the issue's public
LlmAgent+AgentCardBuilder.build()flow with an instruction provider. Before the change it raisedRuntimeErrorwrappingTypeError; after the change it returns a card without invoking the provider.Checklist
Additional context
The Agent Card is static and has no session or invocation context. Skipping runtime providers avoids executing user code with fabricated context and avoids exposing context-dependent instructions in card metadata.