Skip to content

fix: enforce path boundary in built-in agent file tools (path traversal) #5615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adilburaksen wants to merge 3 commits into
base: main
Choose a base branch
from
+52 −16
Open

fix: enforce path boundary in built-in agent file tools (path traversal) #5615

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2593d6
fix: enforce path boundary in built-in agent file tools
adilburaksen May 6, 2026
67be87b
Merge branch 'main' into fix/path-traversal-only
rohityan May 8, 2026
f7de440
style: apply pyink formatting (merge split f-string)
adilburaksen May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
style: apply pyink formatting (merge split f-string)
  • Loading branch information
@adilburaksen
adilburaksen committed May 8, 2026
commit f7de44064370c80896f5995a869e2a385f490548
3 changes: 1 addition & 2 deletions src/google/adk/cli/built_in_agents/utils/resolve_root_directory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,7 @@ def resolve_file_path(
candidate.relative_to(resolved_root)
except ValueError as e:
raise ValueError(
f'Path {file_path!r} resolves outside project root'
f' {resolved_root!r}'
f'Path {file_path!r} resolves outside project root {resolved_root!r}'
) from e

return candidate
Expand Down