Skip to content

fix: make _EvalMetricResultWithInvocation.expected_invocation Optional for conversation_scenario support #5215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ankursharmas merged 2 commits into from
Apr 14, 2026
+7 −1
Merged

fix: make _EvalMetricResultWithInvocation.expected_invocation Optional for conversation_scenario support #5215

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b1edaa
fix: make _EvalMetricResultWithInvocation.expected_invocation Optional
ASRagab Apr 8, 2026
d3d56b6
Merge branch 'main' into fix/optional-expected-invocation
ankursharmas Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/google/adk/evaluation/agent_evaluator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ class _EvalMetricResultWithInvocation(BaseModel):
"""

actual_invocation: Invocation
expected_invocation: Invocation
expected_invocation: Optional[Invocation] = None
Comment thread
ASRagab marked this conversation as resolved.
eval_metric_result: EvalMetricResult


Expand Down Expand Up @@ -438,15 +438,21 @@ def _print_details(
"threshold": threshold,
"prompt": AgentEvaluator._convert_content_to_text(
per_invocation_result.expected_invocation.user_content
if per_invocation_result.expected_invocation
else per_invocation_result.actual_invocation.user_content
),
"expected_response": AgentEvaluator._convert_content_to_text(
per_invocation_result.expected_invocation.final_response
if per_invocation_result.expected_invocation
else None
),
"actual_response": AgentEvaluator._convert_content_to_text(
per_invocation_result.actual_invocation.final_response
),
"expected_tool_calls": AgentEvaluator._convert_tool_calls_to_text(
per_invocation_result.expected_invocation.intermediate_data
if per_invocation_result.expected_invocation
else None
),
"actual_tool_calls": AgentEvaluator._convert_tool_calls_to_text(
per_invocation_result.actual_invocation.intermediate_data
Expand Down
Loading