fix: strip timezone from datetime for MySQL to prevent stale-writer false positive#5209
Open
enjoykumawat wants to merge 1 commit intogoogle:mainfrom
Open
fix: strip timezone from datetime for MySQL to prevent stale-writer false positive#5209enjoykumawat wants to merge 1 commit intogoogle:mainfrom
enjoykumawat wants to merge 1 commit intogoogle:mainfrom
Conversation
…alse positive MySQL DATETIME(fsp=6) silently drops timezone info on storage, so a tz-aware datetime written by create_session produces a different _storage_update_marker string than the naive datetime read back by append_event, causing a false ValueError on the first append after create. The code already handled this for SQLite and PostgreSQL but not MySQL. Add MySQL to the timezone stripping check. Fixes google#5085
Collaborator
|
/gemini review |
9 tasks
Collaborator
|
Hi @enjoykumawat , Thank you for your contribution! We appreciate you taking the time to submit this pull request. Your PR has been received by the team and is currently under review. We will provide feedback as soon as we have an update to share. |
Collaborator
|
Hi @wukath , can you please review this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_session()alongside SQLite and PostgreSQLDATETIME(fsp=6)silently drops timezone info, causing_storage_update_markermismatch on firstappend_event()Root Cause
create_session()creates a tz-aware datetime (tz=timezone.utc) and derives the_storage_update_markerfrom it (includes+00:00). MySQLDATETIMEdrops timezone on storage. Whenappend_event()readsupdate_timeback, it gets a naive datetime, produces a different marker string, and the strict comparison fails withValueError: The session has been modified in storage since it was loaded.The code already handled this for SQLite and PostgreSQL (line 464) but MySQL was missing.
Test Plan
Fixes #5085