Skip to content

fix: populate required fields in FunctionDeclaration json_schema fallback #5000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
giulio-leone wants to merge 2 commits into from
Closed

fix: populate required fields in FunctionDeclaration json_schema fallback #5000

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ca1849
fix: populate required fields in FunctionDeclaration json_schema fall…
giulio-leone Mar 14, 2026
e9783d7
test(tools): pyink format required-fields fallback test
giulio-leone Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test(tools): pyink format required-fields fallback test 
Clear the pyink failure on PR #4812 after validating the json_schema fallback behavior with targeted pytest and a runtime reproduction script.
  • Loading branch information
@giulio-leone
giulio-leone committed Apr 8, 2026
commit e9783d74f88c2d3a4b0818ab71b9bc8659f5037e
2 changes: 1 addition & 1 deletion tests/unittests/tools/test_from_function_with_options.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ def test_required_fields_set_in_json_schema_fallback():

def complex_tool(
query: str,
mode: str = "default",
mode: str = 'default',
tags: list[str] | None = None,
) -> str:
"""A tool where one param has a complex union type."""
Expand Down
Loading