Skip to content

chore: Renames settings.json to be settings.recommendation.json and enhance .gitignore content #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Oct 3, 2025
Merged

chore: Renames settings.json to be settings.recommendation.json and enhance .gitignore content #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: Renames settings.json to be settings.recommendation.json and e… 
…nhance .gitignore content

- It's not a good practice to enforce settings.json, since each developer may have different settings of their specific IDE env.
- It's no-harm to have a recommended template to start with.
- `extensions.json` is good, since it gives suggestion on the useful vs code extensions.

PiperOrigin-RevId: 814834055
  • Loading branch information
@Jacksunwei @copybara-github
Jacksunwei authored and copybara-github committed Oct 3, 2025
commit 17ea3424a88350d59c6def8eb982d5c38997dd6b
32 changes: 31 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,32 @@
# Compiled class files
*.class

# Log files
*.log

# Package Files
*.jar
*.war
*.nar
*.ear
*.zip
*.tar.gz
*.rar

# Maven target directory
target/
.idea
.mvn/

# IntelliJ IDEA files
.idea/
*.iml
*.ipr
*.iws
out/

# VS Code files
.vscode/settings.json

# OS-specific junk
.DS_Store
Thumbs.db
2 changes: 2 additions & 0 deletions .vscode/settings.json → .vscode/settings.recommended.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
{
// A recommended set of settings for VS Code.
//
// formatOnType and formatOnPaste is a very bad idea for slow formatters
// (such as an external Google Java Format invocation exec), so just on Save:
"editor.formatOnSave": true,
Expand Down