feat: filter duplicate A2A event parts per conversation turn in agent executor#1092
Open
nan-yu wants to merge 2 commits intogoogle:mainfrom
Open
feat: filter duplicate A2A event parts per conversation turn in agent executor#1092nan-yu wants to merge 2 commits intogoogle:mainfrom
nan-yu wants to merge 2 commits intogoogle:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a filtering mechanism for duplicate A2A event parts in agent_executor.py. Feedback highlights a memory leak and thread-safety risk from using a class-level dictionary, a logic inconsistency in the reset conditions, and performance overhead from JSON serialization. Furthermore, the PR lacks required unit tests and a completed pre-review checklist as specified in the style guide.
Collaborator
jacobsimionato
left a comment
There was a problem hiding this comment.
Do you understand the source of the duplicates here? I worry that this change might mask real issues elsewhere in the system. Shouldn't ADK etc manage this correctly under the hood?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before
Duplicate.results.webm
After
Duplicate.results.-.fix.webm