Skip to content

Fixed "print function's "end" option error in CPython" #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Sungmin-Joo wants to merge 2 commits into from
Closed

Fixed "print function's "end" option error in CPython" #92

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a587ba
Fix "end" option in print function
Sungmin-Joo Sep 27, 2019
0d6c264
add "end" test in cpython
Sungmin-Joo Sep 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add "end" test in cpython 
add "end" test in cpython
  • Loading branch information
@Sungmin-Joo
Sungmin-Joo committed Sep 27, 2019
commit 0d6c264509c9ccbffee385acd46bde7ce80cd635
6 changes: 6 additions & 0 deletions builtin/tests/builtin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,12 @@ def gen2():
ok = True
assert ok, "TypeError not raised"

try:
print("hello","gpython", end="123\n")
Copy link
Copy Markdown
Member

@sbinet sbinet Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print("hello","gpython", end="123\n")
print("hello", "gpython", end="123\n")

except TypeError as e:
ok = True
assert ok, "TypeError not raised"
Copy link
Copy Markdown
Member

@sbinet sbinet Sep 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert ok, "TypeError not raised"
assert ok, "TypeError not raised when 'sep' is not in the kwargs dict"

that said, I am not sure I understand this test.
do we really want this line to raise an exception? why?


try:
print("hello", sep=" ", end=1)
except TypeError as e:
Expand Down