Skip to content

Adding split method to string class #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ncw merged 6 commits into from
May 28, 2019
Merged

Adding split method to string class #60

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a8debc6
Adding split method to string class
kellrott May 17, 2019
cd235f2
Adding test for str split method
kellrott May 17, 2019
d3c579d
Fixing .split exception and added more python tests
kellrott May 24, 2019
f7ab626
Closer matching to python string split behavior
kellrott May 24, 2019
2f4feef
Fixing error message so it matches one from python3.4
kellrott May 28, 2019
e316b2b
Fixing error message to match python3.4 (previous version was python3.7)
kellrott May 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixing error message so it matches one from python3.4
  • Loading branch information
@kellrott
kellrott committed May 28, 2019
commit 2f4feef9522af3a34fc2b5fa300dd744e5a1c148
2 changes: 1 addition & 1 deletion py/string.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ func init() {
} else if _, ok := value.(NoneType); ok {
valArray = fieldsN(string(selfStr), maxSplit)
} else {
return nil, ExceptionNewf(TypeError, "descriptor 'split' requires a 'str' object but received a '%s'", value.Type())
return nil, ExceptionNewf(TypeError, "must be str or None, not %s", value.Type())
}
o := List{}
for _, j := range valArray {
Expand Down
2 changes: 1 addition & 1 deletion py/tests/string.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ class C():
assert ['a', 'd,c'] == list("a,d,c".split(",",1))
assert ['a', 'd', 'b'] == list(" a d b ".split())
assert ['a', 'd b '] == list(" a d b ".split(None, 1))
assertRaisesText(TypeError, "descriptor 'split' requires a 'str' object but received a 'int'", lambda: "0,1,2,4".split(1))
assertRaisesText(TypeError, "must be str or None, not int", lambda: "0,1,2,4".split(1))

doc="ascii len"
assert len(asc) == 5
Expand Down