Skip to content

Adding iterator method to Dict #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ncw merged 8 commits into from
Jun 3, 2019
Merged

Adding iterator method to Dict #59

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
93a9f40
Adding iterator method to Dict
kellrott May 17, 2019
abedc25
Fixing formatting
kellrott May 17, 2019
30a14d7
Adding test for dict iterator
kellrott May 17, 2019
f85056c
Adding some docs
kellrott May 24, 2019
7d9728d
Changing docs
kellrott May 28, 2019
6b49912
Fixing error in test
kellrott May 28, 2019
3604157
Extending dict __iter__ tests
kellrott May 28, 2019
a39291e
Adding items method to dict
kellrott Jun 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Changing docs
  • Loading branch information
@kellrott
kellrott committed May 28, 2019
commit 7d9728d200a2059bc87c617ed6cf77a775db05b2
2 changes: 1 addition & 1 deletion py/tests/dict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
a = repr({"a":"b","c":5.5})
assert a == "{'a': 'b', 'c': 5.5}" or a == "{'c': 5.5, 'a': 'b'}"

doc="in"
doc="check __iter__"
a = repr({"a":"b","c":5.5})
assert "a" in a
Copy link
Copy Markdown
Collaborator

@ncw ncw May 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking this test will no longer work when we implement the __contains__ method for dict.

Do can you change it to something like

l =  list(iter(a))
assert "a" in l
assert "c" in l
assert len(l) == 2

Copy link
Copy Markdown
Contributor Author

@kellrott kellrott May 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed now


Expand Down