Skip to content

print should use __str__ or __repr__ when available #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ncw merged 1 commit into from
Sep 8, 2018
Merged

print should use __str__ or __repr__ when available #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
print should use __str__ or __repr__ when available
  • Loading branch information
@raff
raff committed Sep 7, 2018
commit a7252c0a1a8ecc9beeb7a40a0d0fc2b790ebb0c3
5 changes: 5 additions & 0 deletions builtin/builtin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,11 @@ func builtin_print(self py.Object, args py.Tuple, kwargs py.StringDict) (py.Obje
end := endObj.(py.String)
// FIXME ignoring file and flush
for i, v := range args {
v, err := py.Str(v)
if err != nil {
return nil, err
}

fmt.Printf("%v", v)
if i != len(args)-1 {
fmt.Print(sep)
Expand Down