Skip to content

stdlib/string: first import #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbinet merged 3 commits into from
Mar 25, 2022
Merged

stdlib/string: first import #175

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d9f636
py: add handling of format 'n' to ParseTupleAndKeywords
sbinet Mar 25, 2022
8ed73c5
py: refactor str.split into String.Split
sbinet Mar 25, 2022
7595575
stdlib/string: first import
sbinet Mar 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
py: refactor str.split into String.Split
  • Loading branch information
@sbinet
sbinet committed Mar 25, 2022
commit 8ed73c5e5d8026bfbc58bab863206142b929d88b
84 changes: 44 additions & 40 deletions py/string.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,37 +122,8 @@ func fieldsN(s string, n int) []string {
}

func init() {
StringType.Dict["split"] = MustNewMethod("split", func(self Object, args Tuple) (Object, error) {
selfStr := self.(String)
var value Object = None
zeroRemove := true
if len(args) > 0 {
if _, ok := args[0].(NoneType); !ok {
value = args[0]
zeroRemove = false
}
}
var maxSplit int = -2
if len(args) > 1 {
if m, ok := args[1].(Int); ok {
maxSplit = int(m)
}
}
var valArray []string
if valStr, ok := value.(String); ok {
valArray = strings.SplitN(string(selfStr), string(valStr), maxSplit+1)
} else if _, ok := value.(NoneType); ok {
valArray = fieldsN(string(selfStr), maxSplit)
} else {
return nil, ExceptionNewf(TypeError, "Can't convert '%s' object to str implicitly", value.Type())
}
o := List{}
for _, j := range valArray {
if len(j) > 0 || !zeroRemove {
o.Items = append(o.Items, String(j))
}
}
return &o, nil
StringType.Dict["split"] = MustNewMethod("split", func(self Object, args Tuple, kwargs StringDict) (Object, error) {
return self.(String).Split(args, kwargs)
}, 0, "split(sub) -> split string with sub.")

StringType.Dict["startswith"] = MustNewMethod("startswith", func(self Object, args Tuple) (Object, error) {
Expand Down Expand Up @@ -597,13 +568,46 @@ func (s String) M__contains__(item Object) (Object, error) {
return NewBool(strings.Contains(string(s), string(needle))), nil
}

func (s String) Split(args Tuple, kwargs StringDict) (Object, error) {
var (
pyval Object = None
pymax Object = Int(-2)
pyfmt = "|Oi:split"
kwlst = []string{"sep", "maxsplit"}
)
err := ParseTupleAndKeywords(args, kwargs, pyfmt, kwlst, &pyval, &pymax)
if err != nil {
return nil, err
}

var (
max = pymax.(Int)
vs []string
)
switch v := pyval.(type) {
case String:
vs = strings.SplitN(string(s), string(v), int(max)+1)
case NoneType:
vs = fieldsN(string(s), int(max))
default:
return nil, ExceptionNewf(TypeError, "Can't convert '%s' object to str implicitly", pyval.Type())
}
o := List{}
for _, j := range vs {
o.Items = append(o.Items, String(j))
}
return &o, nil
}

// Check stringerface is satisfied
var _ richComparison = String("")
var _ sequenceArithmetic = String("")
var _ I__mod__ = String("")
var _ I__rmod__ = String("")
var _ I__imod__ = String("")
var _ I__len__ = String("")
var _ I__bool__ = String("")
var _ I__getitem__ = String("")
var _ I__contains__ = String("")
var (
_ richComparison = String("")
_ sequenceArithmetic = String("")
_ I__mod__ = String("")
_ I__rmod__ = String("")
_ I__imod__ = String("")
_ I__len__ = String("")
_ I__bool__ = String("")
_ I__getitem__ = String("")
_ I__contains__ = String("")
)