Repository navigation
git: worktree, fix Add silently failing for absolute paths - #1949
Merged
Merged
Conversation
Convert absolute paths to worktree-relative paths in doAdd() before updating the index. Return an error if the path is outside the worktree root. Previously, absolute paths passed through filepath.Clean but were never relativized, causing the file to not be tracked. Fixes #1460
Contributor
Author
You bet! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Worktree.Add()silently fails when given an absolute path. No error is returned, but the file is not added to the index because the index stores relative paths.The fix converts absolute paths to worktree-relative paths using
filepath.Rel()before updating the index. If the path is outside the worktree root, an error is returned.Link to tracking issue
Fixes #1460
Testing
Added
TestAddAbsolutePathwhich:w.Add()with the absolute pathgo test ./...andgo vet ./...pass.Documentation
N/A - behavior now matches
git add /absolute/path.This contribution was developed with AI assistance (Codex).