Skip to content

fix: filter on date range before file#1909

Open
gbonnefille wants to merge 6 commits intogo-git:mainfrom
gbonnefille:fix-log-filtering-order
Open

fix: filter on date range before file#1909
gbonnefille wants to merge 6 commits intogo-git:mainfrom
gbonnefille:fix-log-filtering-order

Conversation

@gbonnefille
Copy link
Copy Markdown

It is much more efficient to evaluate a date range than checking all files of a commit.

Fixes #1659

It is much more efficient to evaluate a date range than checking all files of a commit.
@onee-only
Copy link
Copy Markdown
Contributor

Would you rebase your PR and run make validate-lint? Also It'll be great if you can add the benchmark code at #1659 (comment) to your PR and share the benchmark result.

@gbonnefille
Copy link
Copy Markdown
Author

Would you rebase your PR and run make validate-lint? Also It'll be great if you can add the benchmark code at #1659 (comment) to your PR and share the benchmark result.

I update my PR to latest main branch.
I integrated the suggested bench.

There are still some warnings on this new code (fmt.Appendf).
@AriehSchneier any idea?

@AriehSchneier
Copy link
Copy Markdown
Contributor

Would you rebase your PR and run make validate-lint? Also It'll be great if you can add the benchmark code at #1659 (comment) to your PR and share the benchmark result.

I update my PR to latest main branch. I integrated the suggested bench.

There are still some warnings on this new code (fmt.Appendf). @AriehSchneier any idea?

If you ask something like chatgpt it will give you a good explanation, the linter has been upgraded and is picking up more, you need to replace []byte(fmt.Sprintf( with fmt.Appendf(nil, (remembering to delete the extra ) at the end)

@gbonnefille
Copy link
Copy Markdown
Author

Would you rebase your PR and run make validate-lint? Also It'll be great if you can add the benchmark code at #1659 (comment) to your PR and share the benchmark result.

I update my PR to latest main branch. I integrated the suggested bench.
There are still some warnings on this new code (fmt.Appendf). @AriehSchneier any idea?

If you ask something like chatgpt it will give you a good explanation, the linter has been upgraded and is picking up more, you need to replace []byte(fmt.Sprintf( with fmt.Appendf(nil, (remembering to delete the extra ) at the end)

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Performance issue on log with file filter and date range

3 participants