Open
Conversation
0xDEC0DE
commented
Mar 5, 2026
|
|
||
| var ( | ||
| worktreeNameRE = regexp.MustCompile(`^[a-zA-Z0-9\-]+$`) | ||
| worktreeNameRE = regexp.MustCompile(`^[a-zA-Z0-9._\-]+$`) |
Contributor
Author
There was a problem hiding this comment.
I'm honestly at a loss as to why this guard is here. git worktree add is profoundly forgiving when it comes to the names of worktrees, I'm pretty sure it accepts anything that is allowed in a pathname, i.e., nearly the full Unicode character set is allowed.
But at minimum, accepting all the common characters you're likely to find in a Unix pathname is a better place to be in.
6238fe1 to
3ef85d5
Compare
80d4e07 to
ba5bc3c
Compare
Update the FuzzAdd test in x/plumbing/worktree/worktree_test.go to capture whether the Add command should throw an error or not, rather than leaving it up to a regex expansion. This can help surface bugs in the regex itself. Also update the regex to expand what it considers a valid name.
ba5bc3c to
9d49367
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the FuzzAdd test in x/plumbing/worktree/worktree_test.go to capture whether the Add command should throw an error or not, rather than leaving it up to a regex expansion. This can help surface bugs in the regex itself.
Also update the regex to expand what it considers a valid name.