Skip to content

Use PyLong_GetSign()#486

Closed
skirpichev wants to merge 3 commits intogmpy2:masterfrom
skirpichev:use-pylong-getsign
Closed

Use PyLong_GetSign()#486
skirpichev wants to merge 3 commits intogmpy2:masterfrom
skirpichev:use-pylong-getsign

Conversation

@skirpichev
Copy link
Copy Markdown
Member

See python/cpython#116561 and capi-workgroup/decisions#19. I'm not happy with this API and it seems that discussion is ongoing. Maybe it's wise to wait some time...

@skirpichev skirpichev force-pushed the use-pylong-getsign branch 2 times, most recently from 724432c to 32aeb00 Compare June 4, 2024 04:03
@skirpichev
Copy link
Copy Markdown
Member Author

skirpichev commented Jun 13, 2024

Probably, discussion in capi-workgroup/decisions#19 is ended.
But see capi-workgroup/decisions#29

@skirpichev skirpichev force-pushed the use-pylong-getsign branch from 9770628 to a3c4175 Compare June 13, 2024 07:34
@skirpichev skirpichev force-pushed the use-pylong-getsign branch from a3c4175 to fbf99e6 Compare June 13, 2024 10:44
@casevh
Copy link
Copy Markdown
Contributor

casevh commented Jun 26, 2024

Should this be merged now and then released as 2.2.0 or should this wait until 2.2.1?

@skirpichev
Copy link
Copy Markdown
Member Author

Should this be merged now and then released as 2.2.0

I don't think so. capi-workgroup/decisions#29 is open. We should wait, see also https://discuss.python.org/t/c-api-working-group-vacancy-again/56167

This pr shouldn't block 2.2 release. I'll just mark it as a draft.

@skirpichev skirpichev marked this pull request as draft June 26, 2024 06:59
@skirpichev
Copy link
Copy Markdown
Member Author

I don't like it, but probably capi-workgroup/decisions#35 API will have negative field. So, probably we can skip this.

@skirpichev skirpichev closed this Sep 13, 2024
@skirpichev skirpichev deleted the use-pylong-getsign branch September 13, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants