Infowindow - #15
Closed
sandrotosi wants to merge 6 commits into
Closed
Conversation
This function takes 2 sets of arguments, the North-East Lat/Lng and the South-West Lat/Lng, which are used to compute a LatLngBounds() which is then passed to the gmap fitBounds() method. The result is a map with the correct zoom to show the NE-SW region. As a possible improvement, we could automatically store the NE/SW corners for every new object added to the map (via gmplot methods) and then just 'requesting' to fit those bounds by flipping a True/False flag.
Symbols are items like circles or arrows that can be used in other GMap objects, but only after they have been defined. add_symbol() append a symbol to the current map symbols list which you can then use in polylines/markers Reference: https://developers.google.com/maps/documentation/javascript/symbols
the 'icons' parameters of Polyline allows you to add a symbol to the line. Ref: https://developers.google.com/maps/documentation/javascript/symbols#add_to_polyline
The rename makes more explicit we are writing markers; the addition of a 'name' optional argument is needed to support the (upcoming) info windows, as they require to have a unique identifier for the marker they are associated with.
A info window is a marker with a message window associated to it, so that clicking on the marker, that window is shown. Ref: https://developers.google.com/maps/documentation/javascript/infowindows
Contributor
Author
|
@vgm64 ping |
|
Hi, I am having trouble displaying the "contents" in the InfoWindow. gmap = gmplot.GoogleMapPlotter(37.428, -122.145, 15) gmap.draw('map.html')I can see an InfoWindow but no contents. Thanks. |
Contributor
Author
|
you have to make the content of (note the additional quotes araund show content), anyway it doesnt look like this will be merged anytime soon |
|
Ah, thank you for the explanation! |
Closed
vgm64
force-pushed
the
master
branch
7 times, most recently
from
March 4, 2018 07:22
823e3ad to
ad6df42
Compare
Closed
Closed
Contributor
Author
|
updated at #125 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.