Merged
Conversation
The `--nosummary` flag was inverted, which cause it to always be true.
Rather than just flip `store_false` to `store_true`, I opted to refactor the
internal name from `nosummary` to `showSummary`. This avoids double-negatives
("Are we not not showing the summary?"), making the logic easier to follow and
easier to find bugs in. I left the flag name as-is for compatability reasons.
Fixes glamp#1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--nosummaryflag was inverted, which cause it to always be true.Rather than just flip
store_falsetostore_true, I opted to refactor theinternal name from
nosummarytoshowSummary. This avoids double-negatives("Are we not not showing the summary?"), making the logic easier to follow and
easier to find bugs in. I left the flag name as-is for compatability reasons.
Fixes #1.