refactor: use python-gitlab in acceptance tests#442
refactor: use python-gitlab in acceptance tests#442gdubicki merged 8 commits intogitlabform:mainfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
==========================================
- Coverage 84.21% 78.94% -5.27%
==========================================
Files 70 70
Lines 2679 2641 -38
==========================================
- Hits 2256 2085 -171
- Misses 423 556 +133
|
ccaf2cf to
d0e1043
Compare
d0e1043 to
0b6fb94
Compare
0b6fb94 to
3961751
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hey @nejch! Many thanks for your effort! I absolutely do not think that it is bad that this is a big PR - it is great that you covered almost all of the tests in one shot. Maybe I will try to do the remaining premium ones myself so I can see how the conversion works? The only thing that slightly blocks merging this is the final release of v3.4.0. I want to complete work on that first as it contains the long-awaited feature AND also a big refactor and it's almost ready to be released. |
@gdubicki ah that's great to hear! No worries about doing another release first. I can clean this up a bit in the meantime (starting to get conflicts). Should I wait and rebase after the v3.4.0 release? That makes sense if you want to try out |
|
@gdubicki if I understand correctly I can start rebasing once 3.4.0 is out right? I'm starting to see some conflicts so not sure if I should keep this up to date here already :) |
Yes. Sorry for keeping you waiting but I've been busier than I thought lately and it's hard for me to complete that 3.4.0... |
3961751 to
b5377a7
Compare
b5377a7 to
75d1f0c
Compare
|
Hey @gdubicki thanks for the ping and sorry for the delay 😊 I see you've already resolved the conflicts, thanks! I can work on finishing the premium tests some time next week/weekend if that works for you? Or would you prefer to work on that? |
Yes, I resolved conflicts in the standard tests but it would be great if you could update the premium ones. |
|
Ugh, the new black version forced me to remove some empty lines and now git can't handle merging that? :/ |
|
add revert commit to this branch of the black changes of matching files? :) |
75d1f0c to
39c27aa
Compare
050fc41 to
4803d4a
Compare
4803d4a to
d5fa066
Compare
d5fa066 to
60c1898
Compare
|
@gdubicki I think this should be ready now 🙇 I've resolved some of the comments so it's not too noisy but feel free to expand to see the reasoning. |
|
@gdubicki I pushed another small commit here last week, would be interested to see if it's all green for Premium as well, would you mind approving the premium deployment? :) |
|
Thank you again for all your work on this @nejch! All tests have been passing, so I am happy to be able to merge. 😊 |
Related to #73
A while ago I promised I'd give it a shot migrating to python-gitlab so we can collaborate more and reduce effort.
One of our users pinged me recently so I looked again now and the code is a bit involved to migrate as it's also reused in tests, so I thought maybe I can decouple the test code first and not touch production code.
Turns out, there's always more tests than code so this ended being a massive refactor 😅 Sorry, thought I'd start small but it seemed cleaner to migrate all tests. However, it was great that all testing is done as blackbox acceptance testing as I didn't need to change any mocks.
So, here's a massive PR if this is something you'd consider. Slightly ashamed of this chunky boy here but still 😁 I'll add PR notes on the changes a bit along the way. I haven't yet done the
premiumpart as I need to set up a local instance now, but opening a draft just to get a general idea of the direction here.tests/acceptance/__init__.pyandtests/acceptance/conftest.py, most of the test files are cosmetics due to dot-notation in python-gitlab objects.gl.has_no_licenseetcReally sorry about the massive diff here 🙇