Skip to content

fix: prevent KeyError when using --output with application settings - #1384

Merged
amimas merged 3 commits into
gitlabform:mainfrom
rickbrouwer:issue-1383
Aug 9, 2026
Merged

fix: prevent KeyError when using --output with application settings#1384
amimas merged 3 commits into
gitlabform:mainfrom
rickbrouwer:issue-1383

Conversation

@rickbrouwer

Copy link
Copy Markdown
Collaborator

The application section is processed with an empty string key but without a preceding add_placeholder() call, so writing the effective configuration raised KeyError: ''. Make add_configuration create the container if missing.

Fixes #1383

Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
@rickbrouwer
rickbrouwer requested a review from TimKnight01 July 30, 2026 14:50
@rickbrouwer
rickbrouwer temporarily deployed to Integrate Pull Request July 30, 2026 14:50 — with GitHub Actions Inactive
@rickbrouwer
rickbrouwer temporarily deployed to Integrate Pull Request July 30, 2026 14:50 — with GitHub Actions Inactive
Comment thread gitlabform/output.py Outdated
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
@rickbrouwer
rickbrouwer temporarily deployed to Integrate Pull Request August 9, 2026 12:08 — with GitHub Actions Inactive
@rickbrouwer
rickbrouwer temporarily deployed to Integrate Pull Request August 9, 2026 12:08 — with GitHub Actions Inactive

@amimas amimas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@amimas
amimas temporarily deployed to Integrate Pull Request August 9, 2026 20:38 — with GitHub Actions Inactive
@amimas
amimas temporarily deployed to Integrate Pull Request August 9, 2026 20:38 — with GitHub Actions Inactive
@amimas
amimas enabled auto-merge (squash) August 9, 2026 20:39
@amimas
amimas merged commit 3e9e893 into gitlabform:main Aug 9, 2026
23 checks passed
@rickbrouwer
rickbrouwer deleted the issue-1383 branch August 10, 2026 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cant specify --output flag when setting application settings

2 participants