Repository navigation

Commit 8d64683

authored

logging: clear null trace_id (googleapis#2760)

To ThreadLocal, set(null) and remove() are functionally similar but remove() clears out the map-entry so it's more space-efficient. Fixes googleapis#2746.

1 parent 19c22a6 commit 8d64683Copy full SHA for 8d64683

1 file changed

google-cloud-logging/src/main/java/com/google/cloud/logging
- TraceLoggingEnhancer.java

`‎google-cloud-logging/src/main/java/com/google/cloud/logging/TraceLoggingEnhancer.java‎`

-Original file line number
+Diff line change
    * @param id The traceID
    */
   public static void setCurrentTraceId(String id) {
 -    traceId.set(id);
 +    if (id == null) {
 +      traceId.remove();
 +    } else {
 +      traceId.set(id);
 +    }
+  }
   /**

Comments

(0)